Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: turn off ak's typetracer _new checks during optimize #486

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

martindurant
Copy link
Collaborator

Will have no effect until scikit-hep/awkward#3054 is out

@lgray , any other places we need this optimisation?

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 93.01%. Comparing base (8cb8994) to head (dcd1f65).
Report is 60 commits behind head on main.

Files Patch % Lines
src/dask_awkward/lib/inspect.py 76.47% 4 Missing ⚠️
src/dask_awkward/lib/utils.py 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   93.06%   93.01%   -0.06%     
==========================================
  Files          23       23              
  Lines        3290     3336      +46     
==========================================
+ Hits         3062     3103      +41     
- Misses        228      233       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martindurant martindurant changed the title Turn of ak's typetracer _new checks during optimize [feat[ Turn of ak's typetracer _new checks during optimize Mar 15, 2024
@martindurant martindurant changed the title [feat[ Turn of ak's typetracer _new checks during optimize [feat] Turn of ak's typetracer _new checks during optimize Mar 15, 2024
@martindurant martindurant changed the title [feat] Turn of ak's typetracer _new checks during optimize [feat] Turn off ak's typetracer _new checks during optimize Mar 15, 2024
@lgray
Copy link
Collaborator

lgray commented Mar 15, 2024

During dak.necessary_columns as well. Though that has some slowness that's kind of strange but different, it hasn't been high priority. This will help, of course.

@jpivarski
Copy link
Collaborator

If you specify the lines of code that should be avoided, I'll add them to this PR (with only one global switch for all).

@martindurant
Copy link
Collaborator Author

During dak.necessary_columns as well.

OK, but that's not actually something we've been talking about in our benchmarking recently. I suppose the columns opt is actually the only place we need this right now (although it would be nice throughout graph build time too). I wouldn't be opposed to a public function that can turn the flag and keep it that way for the whole session.

@lgray
Copy link
Collaborator

lgray commented Mar 15, 2024

Yeah I haven't fully thought through or experienced the user-side lifecycle of necessary_columns... I have no idea if people use it a lot directly and if it needs to be snappy.

@jpivarski jpivarski changed the title [feat] Turn off ak's typetracer _new checks during optimize feat: turn off ak's typetracer _new checks during optimize Mar 15, 2024
@martindurant martindurant requested a review from lgray March 19, 2024 18:23
@martindurant
Copy link
Collaborator Author

OK, will merge this now, and we can add more blocks or set a global state in the future, if we decide.

@martindurant martindurant merged commit 052aff5 into dask-contrib:main Mar 26, 2024
24 checks passed
@martindurant martindurant deleted the typetracer_nockeck branch March 26, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants