Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky errors in package:dds on service_2/break_on_function_many_child_isolates_test/dds #46826

Closed
alexmarkov opened this issue Aug 5, 2021 · 0 comments
Closed

Flaky errors in package:dds on service_2/break_on_function_many_child_isolates_test/dds #46826

alexmarkov opened this issue Aug 5, 2021 · 0 comments
Assignees
@bkonyi
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening pkg-dds For issues related to the Dart Development Service

Comments

@alexmarkov
Copy link
Contributor 

tools/test.py --repeat 10 -n dartk-linux-release-x64 service_2/break_on_function_many_child_isolates_test

service_2/break_on_function_many_child_isolates_test/service passed all runs, service_2/break_on_function_many_child_isolates_test/dds failed 7/10 times.

From the log:

00:03 ^[[32m+0^[[0m^[[31m -1^[[0m: break_on_function_many_child_isolates_test.dart (DDS) ^[[1m^[[31m[E]^[[0m^[[0m

  Null check operator used on a null value

  package:dds/src/isolate_manager.dart 165:24  IsolateManager._updateIsolateState.<fn>
  package:dds/src/utils/mutex.dart 22:35       Mutex.runGuarded
  

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.
  Null check operator used on a null value

  package:dds/src/isolate_manager.dart 165:24  IsolateManager._updateIsolateState.<fn>
  package:dds/src/utils/mutex.dart 22:35       Mutex.runGuarded
  

Consider enabling the flag chain-stack-traces to receive more detailed exceptions.
For example, 'dart test --chain-stack-traces'.
  Null check operator used on a null value

  package:dds/src/isolate_manager.dart 165:24  IsolateManager._updateIsolateState.<fn>
  package:dds/src/utils/mutex.dart 22:35       Mutex.runGuarded

Logs from the bots:
https://dart-ci.appspot.com/log/vm-kernel-checked-linux-release-x64/dartk-checked-linux-release-x64/11331/service_2/break_on_function_many_child_isolates_test/dds
https://dart-ci.appspot.com/log/vm-kernel-mac-release-x64/dartk-mac-release-x64/15267/service_2/break_on_function_many_child_isolates_test/dds

@bkonyi Could you please take a look?
@alexmarkov alexmarkov added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening pkg-dds For issues related to the Dart Development Service labels Aug 5, 2021
@bkonyi bkonyi self-assigned this Aug 5, 2021
dart-bot pushed a commit that referenced this issue Aug 5, 2021
@bkonyi
Revert "[ package:dds ] Add locking when modifying DDS state via clie…
0b0bb99 
…nt requests"

This reverts commit 0ecfc7d.

Reason for revert: #46826

Original change's description:
> [ package:dds ] Add locking when modifying DDS state via client requests
>
> Fixes #46696
>
> Change-Id: I666b59a0661f4df3b1f0a47aba52096133f5fbb7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209140
> Reviewed-by: Anna Gringauze <annagrin@google.com>

TBR=bkonyi@google.com,annagrin@google.com

Change-Id: Iec89181372a2fc1b8a461e616bbcd23dd6bbd72d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209280
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonyi bkonyi

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening pkg-dds For issues related to the Dart Development Service
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkonyi @alexmarkov