list of corelib dart files is duplicated in too many places #462
Labels
area-core-library
SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries.
Comments
|
This comment was originally written by ngeoffray@google.com The one in corelib is the one that individual projects can use. They don't have to if they want to better control the build. If the one in corelib gets out of sync, that's a bug. But we'll catch it because that's the one the VM uses. Closing the issue. Feel free to reopen it if you think there's something we can do in the library area to help maintain the list in individual projects. Set owner to ngeoffray@google.com. |
DartBot
added
Type-Defect
area-core-library
This was referenced Oct 29, 2020
dart-bot
pushed a commit
that referenced
this issue
Jan 25, 2021
2021-01-24 irina.arkhipets@gmail.com Issue #983: Static warning checks corrected. 2021-01-22 irina.arkhipets@gmail.com Issue #983: triple-shift folders re-named correctly, typo in the library paths updated for 2 tests. 2021-01-21 sgrekhov@unipro.ru Fixes #985. LateInitializationError removed 2021-01-20 sgrekhov@unipro.ru Fixes #982. Add tests for The future value type of an asynchronous non-generator function part of NNBD spec 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-normalization tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD type-aliases tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tripple-shift tests for weak mode added. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added for the override checkings. 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures). 2021-01-19 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode added (Leatest-greatest-closures). 2021-01-18 sgrekhov@unipro.ru Fixes #981. Add tests for Return statements part of NNBD spec 2021-01-18 irina.arkhipets@gmail.com Issue #462: NNBD tests for weak mode corrected according to the current Spec changes. 2021-01-14 irina.arkhipets@gmail.com Issue #462: Additional comments regarding the constant evaluation issues added to weak mode tests. 2021-01-14 sgrekhov@unipro.ru Fixes #980. Remove warnings expectations for overriding default values of optional parameters tests 2021-01-13 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak/flow-analysis directory. 2021-01-12 sgrekhov@unipro.ru #978. Weak mode test changes 2021-01-12 irina.arkhipets@gmail.com Issue #462: Tests for weak mode added to nnbd/weak directory. 2021-01-11 sgrekhov@unipro.ru Fixes #978. Tests updated according to the "flow analysis boolean variable" feature 2020-12-25 irina.arkhipets@gmail.com Issues #463: Tests for weak mode added. 2020-12-25 irina.arkhipets@gmail.com Issues #462, #463: Moved or added new nnbd tests for weak mode, added new tests for strong mode. 2020-12-24 sgrekhov@unipro.ru #970. Usr correct values for ProcessSignal.sigusr1 and ProcessSignal.sigusr2 on Mac 2020-12-24 irina.arkhipets@gmail.com Issue #462: 1. Added nnbd tests for weak mode: exports_*, expression_typing_*, extension_method_resolution_*, future_flattening_*. 2. Moved and re-factored nnbd extension_method_resolution_*, future_flattening_* tests for weak mode into weak folder. 3. Copyrights updated Issue #463: Two exports* tests for strong mode added. 2020-12-24 sgrekhov@unipro.ru Fixes #496. Change tested date to 1 second instead of 1 day to reduce probability to change timezone on DST 2020-12-23 sgrekhov@unipro.ru Fixes #473. Remove UtilsHtml directory 2020-12-23 irina.arkhipets@gmail.com Fix for Issue #462: 1. Added nnbd tests for weak mode: assignability_*, const_evaluation_*, const_objects_*, const_type_var_elimination_*. 2. Moved and re-factored nnbd exports_* tests for weak mode into weak folder. 2020-12-10 sgrekhov@unipro.ru Fixes #976. Remove obsolete errors expectations 2020-12-10 sgrekhov@unipro.ru Fixes #975. Fix wrong expected compile time error type 2020-12-07 sgrekhov@unipro.ru Flag Requirements=nnbd-weak added to the tests that run legacy code Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try Change-Id: I69acc5c0a28fd2e7a2d38f6c9062e5a5854bdfa6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180823 Reviewed-by: William Hesse <whesse@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
May 18, 2022
Changes: ``` > git log --format="%C(auto) %h %s" 9669926..9145f30 https://dart.googlesource.com/intl.git/+/9145f30 Bump actions/checkout from 2 to 3 (#462) https://dart.googlesource.com/intl.git/+/f545753 update the analysis_options.yaml file (#449) https://dart.googlesource.com/intl.git/+/fee2c2d Add a changelog entry for a recent feature (#406) https://dart.googlesource.com/intl.git/+/4e37662 GitHub Sync (#405) https://dart.googlesource.com/intl.git/+/0a14483 Bump dart-lang/setup-dart from 0.3 to 1 (#403) https://dart.googlesource.com/intl.git/+/f22f7b5 fix directive sorting https://dart.googlesource.com/intl.git/+/ed2fbe0 Add dependabot https://dart.googlesource.com/intl.git/+/2518923 Merge pull request #377 from dart-lang/franklinyow-patch-1 https://dart.googlesource.com/intl.git/+/bee0456 Update LICENSE https://dart.googlesource.com/intl.git/+/9bb4bcc Migrating to dart:ffi in Dart 2.12. https://dart.googlesource.com/intl.git/+/532a1e3 Migrating to `dart:ffi` in Dart 2.12 and `package:ffi` 1.0.0. https://dart.googlesource.com/intl.git/+/458129d Replace git dependencies with published versions https://dart.googlesource.com/intl.git/+/5fd7a11 COPYBARA CHANGE FOR dart-archive/intl#358 https://dart.googlesource.com/intl.git/+/2c8e014 Fix typo; see https://screenshot.googleplex.com/5afwL4iQtHeJKLC https://dart.googlesource.com/intl.git/+/33251e0 Prepare to publish for stable null safety (#362) https://dart.googlesource.com/intl.git/+/b3da438 Prep release for beta (#338) https://dart.googlesource.com/intl.git/+/48675cf Prepare a version of intl that supports the 2.12 sdk ``` Diff: https://dart.googlesource.com/intl.git/+/9669926609e7efc17dfd74fbb44ec719a7e573cc~..9145f308f1458f37630a1ffce3b7d3b471ebbc56/ Change-Id: Ic431da0e0785bd4ece86542fae30aad55f384f50 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245222 Commit-Queue: Devon Carew <devoncarew@google.com> Reviewed-by: Nate Bosch <nbosch@google.com>
copybara-service bot
pushed a commit
that referenced
this issue
Sep 21, 2022
Changes: ``` > git log --format="%C(auto) %h %s" 32a9450..87e4c68 https://dart.googlesource.com/markdown.git/+/87e4c68 Bump to 6.0.1 (#462) https://dart.googlesource.com/markdown.git/+/37305cf Add deprecated accessors for indicatorForUncheckedCheckBox and indicatorForCheckedCheckBox (#459) https://dart.googlesource.com/markdown.git/+/2e5e347 lint cleanup (#456) https://dart.googlesource.com/markdown.git/+/a0b5a05 example: small tweak to example – add Dart code (#455) https://dart.googlesource.com/markdown.git/+/de32a69 visitText to use textContent getter so subclassing Text class works correctly. (#431) https://dart.googlesource.com/markdown.git/+/8247955 Rewrite checkbox(task list) extension (#450) https://dart.googlesource.com/markdown.git/+/a602760 Fix crash with mixed checkbox lists (#449) ``` Diff: https://dart.googlesource.com/markdown.git/+/32a94505ded3863b82310b86344a003a19c00341~..87e4c689342d5bbaa84ba2999abf0bff503979be/ Change-Id: I92cf05fe6057e1b3eda8da09fc4eac4f67dd47ab Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260441 Reviewed-by: Samuel Rawlins <srawlins@google.com> Auto-Submit: Devon Carew <devoncarew@google.com> Commit-Queue: Samuel Rawlins <srawlins@google.com>
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue was originally filed by mattsh@google.com
It seems like a slight maintenance problem that we list individual corelib dart files in so many place, roughly the cross-product of (dart+gyp) * (frog + vm + compiler).
E.g., all these files list "collection.dart"
dart/compiler/corelib_sources.gypi
dart/compiler/lib/corelib.dart
dart/corelib/src/corelib_sources.gypi
dart/frog/lib/corelib.dart
dart/frog/lib/frog_corelib_sources.gypi
Is there a way to reduce this down to one list, to make it easier to keep things in sync?
The text was updated successfully, but these errors were encountered: