Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dart2js: crash when using spread in top-level fields #36864

Closed
sigmundch opened this issue May 6, 2019 · 1 comment
Closed

dart2js: crash when using spread in top-level fields #36864

sigmundch opened this issue May 6, 2019 · 1 comment
Assignees
@sigmundch @johnniwinther
Labels
dart2js-crash P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Milestone
D24 Release

Comments

@sigmundch
Copy link
Member

We have an issue in our handling of block expressions in top-level fields. Sample repro:

final _a = {...{1}};
main() => print(_a);

The static type visitor doesn't have a scope yet since we only create it for procedures and function expressions. However, we expect to have one so we can track all the temporary variables added by block expressions.

Also, what's the reason we don't track the variable declaration of Let expressions? Shouldn't we handle it exactly as we would handle the variables in block expressions as well?
@sigmundch sigmundch added P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js dart2js-crash labels May 6, 2019
@sigmundch sigmundch added this to the D24 Release milestone May 6, 2019
@sigmundch
Copy link
Member Author

https://dart-review.googlesource.com/c/sdk/+/101460

@sigmundch sigmundch self-assigned this May 6, 2019
@sigmundch sigmundch mentioned this issue May 17, 2019
Closed
dart-bot pushed a commit that referenced this issue May 21, 2019
@sigmundch @athomas
Ensure we have a scope for variables when visiting fields
07320b3 
Fixes #36864

Change-Id: I66d70cc30b26bd069d4ab5e2b98f0f5954f3ef59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101460
Auto-Submit: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
@sigmundch sigmundch mentioned this issue Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sigmundch sigmundch

@johnniwinther johnniwinther

Labels
dart2js-crash P1 A high priority bug; for example, a single project is unusable or has many test failures web-dart2js
Projects
None yet
Milestone
D24 Release
Development

No branches or pull requests
2 participants
@sigmundch @johnniwinther