No warning for unreachable break

[stevemessick]

while(true) {
...
}

gives no warning if the break statement is missing or unreachable.
////////////////////////////////////////////////////////////////////////////////////
Editor Version: 8124

[bwilkerson]

While this kind of detection is not required by the spec, I do agree that it would be good to have.

---

Added this to the Later milestone.
Removed Priority-Medium label.
Added Priority-Low label.

[bwilkerson]

Removed this from the Later milestone.
Added this to the M3 milestone.

[scheglov]

Removed this from the M3 milestone.
Added this to the Later milestone.
Added AnalysisEngine label.

[DartBot]

This comment was originally written by amouravski@google.com

---

Added Editor-AnalysisEngine label.

[bwilkerson]

Removed AnalysisEngine, Editor-AnalysisEngine labels.

[bwilkerson]

Removed Type-Defect label.
Added Type-Enhancement label.

[bwilkerson]

Added Analyzer-Hint label.

[kasperl]

Removed this from the Later milestone.
Added Oldschool-Milestone-Later label.

[kasperl]

Removed Oldschool-Milestone-Later label.

[srawlins]

"or unreachable" seems strange to pair with this request. Aren't any unreachable statements just dead code (a warning that already exists).

Or, for the following code, would you like two warnings (DEAD_CODE, INFINITE_LOOP):

while (true) {
  // no break statements.
  functionThatCouldThrowOrExit();
  // no break statements.
}

[bwilkerson]

I think he meant "or if the break is unreachable" as in:

while (true) {
  if (3 < 2) break;
}

Basically, don't be fooled just because there is a break statement if it can never get you out of the loop.

[srawlins]

This is a duplicate of a newer bug which has more information, #29196.