Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pybinding for sdk #178

Merged
merged 14 commits into from
Jun 15, 2023
Merged

Pybinding for sdk #178

merged 14 commits into from
Jun 15, 2023

Conversation

freeranged3v
Copy link

@freeranged3v freeranged3v commented Jun 13, 2023

Ready for merge.
Please note the formatting changes for vm.rs, these are from cargo fmt, no semantic changes.

@freeranged3v freeranged3v changed the title Pybinding Pybinding for sdk Jun 13, 2023
@parazyd
Copy link
Member

parazyd commented Jun 13, 2023

@freeranged3v I implemented some pythonic functions for Base and Scalar. Can you do the similar things also for Point?

It should support __add__, __mul__, __sub__, __neg__.

Perhaps also worth adding functionality for += and -= in Base, Scalar, and Point.

@freeranged3v
Copy link
Author

freeranged3v commented Jun 14, 2023

Perhaps also worth adding functionality for += and -= in Base, Scalar, and Point.

FYI, Python automatically implements += with __add__ for example.

@parazyd parazyd merged commit 03e39f2 into darkrenaissance:master Jun 15, 2023
@parazyd
Copy link
Member

parazyd commented Jun 15, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants