Allow overriding environment variable scope

[JeremySkinner]

Allows changing the environment variable scope from Process to User/Machine. Also updated Stop-SshAgent and Get-SshAgent to work with win32 openssh.

[dahlbyk]

I assume this is still WIP, since $Scope isn't actually used yet.

Changes so far look great!

[JeremySkinner]

Yes, I did commit the follow up but looks like I forgot to push it. Will do so when I'm back at my pc.

[rkeithhill]

Is this parameter being used?

[JeremySkinner]

It is now! :) I forgot to commit the change

[JeremySkinner]

@dahlbyk @rkeithhill I've pushed up the missing change.

This doesn't change the environment variable scope for the calls to Get-TempEnv in the main module file, I don't think this is a big deal, but do we want to introduce a global variable to control this? My inclination would be no

[dahlbyk]

setenv doesn't understand your third parameter:

posh-sshell/src/Utils.ps1

Lines 3 to 6 in edcb790

	function setenv($key, $value) {
	[void][Environment]::SetEnvironmentVariable($key, $value)
	Set-TempEnv $key $value
	}

This doesn't change the environment variable scope for the calls to Get-TempEnv in the main module file, I don't think this is a big deal, but do we want to introduce a global variable to control this? My inclination would be no

Get-TempEnv is already explicitly user-scoped rather than process-scoped, and it doesn't make sense for it to be machine-scoped, so I think this is fine. In fact, it doesn't seem useful or correct to allow Start-SshAgent -Scope Machine either, as this could leak the current user's credentials to another user. Am I missing a legitimate scenario for that?

[JeremySkinner]

@dahlbyk Good point, I'll remove the option for machine scope and leave just process/user.

Not sure why my change to setenv isn't showing up in the PR, it shows in my local repo. I'll force push it up.

[JeremySkinner]

@dahlbyk force push seems to have done it, the changes are showing now and I've removed machine scope from the options list.

[dahlbyk]

I'm reasonably certain you can just pass $Scope directly to SetEnvironmentVariable() and PS will automatically cast for you.

[JeremySkinner]

@dahlbyk You're right. I've removed the conversion.