Fix issue where command is never fully ended and following assertions are displayed incorrectly

[panzarino]

• Closes An assertion log will be inserted as a child when outside of a parent command #7731

User facing changelog

Fixes an issue where an assertion log would be displayed as a child while really a parent if no commands were issued in the beforeEach loop.

Additional details

Fixes an internal issue where commands would not be properly closed after executing.

How has the user experience changed?

Notice green dash to the left of "assert"

Before:

After:

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

7644 • 0 • 119 • 0

---

Run details

Project	cypress
Status	Passed
Commit	f6e8e1c
Started	Jun 17, 2020 3:00 PM
Ended	Jun 17, 2020 3:09 PM
Duration	08:58 💡
OS	Linux Debian - 10.1
Browser	Multiple

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[jennifer-shehane]

I can't recreate this issue in 4.8.0 or the develop branch. Are you sure this wasn't introduced in #7356 itself? Can you provide the repro example for the original issue?

I tried using before hooks, tried moving the before hook around the suites...

Below is what I'm seeing in develop branch.

context('closing commands', () => {
  beforeEach(function () {
  })

  it('properly closes commands', () => {
    expect(true).to.be.true
  })
})

context('closing commands', () => {
  beforeEach(function () {
    cy.visit('index.html')
  })

  it('properly closes commands', () => {
    expect(true).to.be.true
  })
})

[panzarino]

@jennifer-shehane I may have described the actual cause of the issue incorrectly. I've since updated the original issue with what I believe to be the actual cause of the bug.

I also realized that this issue was only occuring when I put an .only on the test (due to other commands executing in between, making .then not the last command run). I've moved it to be the first test in cy_spec.js which seemed to accurately test for the error, and now if run without the changes, the test should fail.

[jennifer-shehane]

Looks good 👍

[Saibamen]

What this green dash means?

[jennifer-shehane]

@Saibamen It is used to indicate that the command is a 'child' command, that there is a parent above it.