Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spec loading state and animation #7709

Merged
merged 4 commits into from
Jun 15, 2020
Merged

Add spec loading state and animation #7709

merged 4 commits into from
Jun 15, 2020

Conversation

panzarino
Copy link
Contributor

User facing changelog

Adds a loading state so that a user knows when their tests are loading, especially if it takes longer than usual

How has the user experience changed?

New loading state:

ezgif-6-6aa0b47815bd

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 15, 2020

Thanks for taking the time to open a PR!

@panzarino panzarino changed the title Add loading state and animation Add spec loading state and animation Jun 15, 2020
@cypress
Copy link

cypress bot commented Jun 15, 2020 •
edited
Loading


Test summary

7588 • 0 • 119 • 0

Run details
Project cypress
Status Passed
Commit 1155a6e
Started Jun 15, 2020 8:21 PM
Ended Jun 15, 2020 8:28 PM
Duration 06:53 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

chrisbreiding
chrisbreiding requested changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@chrisbreiding chrisbreiding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just some little nitpicks to take care of.

packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
packages/reporter/src/runnables/runnables.scss Outdated Show resolved Hide resolved
panzarino and others added 3 commits June 15, 2020 16:12
@panzarino panzarino merged commit 6d2e792 into develop Jun 15, 2020
@cypress-bot cypress-bot bot mentioned this pull request Jun 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisbreiding chrisbreiding chrisbreiding approved these changes

@jennifer-shehane jennifer-shehane Awaiting requested review from jennifer-shehane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spec Loading State [TR-41]
2 participants
@panzarino @chrisbreiding