fix: use open instead of connectToNewSpec in electron #27128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 flaky tests on run #48267 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > Shows create from component card for React projects |
Output
Screenshots
Video
|
|
cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > shows No Specs page with specPattern from config |
Output
Screenshots
Video
|
|
cypress\e2e\cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found |
Output
Screenshots
Video
|
|
cypress\e2e\cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution |
Output
Screenshots
Video
|
|
cypress\e2e\scaffold-project.cy.ts • 1 flaky test • launchpad-e2e
| Test | Artifacts | |
|---|---|---|
| scaffolding new projects > scaffolds E2E for a JS project |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
AtofStryker
approved these changes
Jun 26, 2023
| if (options.shouldLaunchNewTab) { | ||
| // if we should launch a new tab and we are not running in electron (which does not support connecting to a new spec) | ||
| // then we can connect to the new spec | ||
| if (options.shouldLaunchNewTab && browser.name !== 'electron') { |
There was a problem hiding this comment.
we might need to check and some tests with #27116 or this (whatever goes in first) to make sure the behavior is expected, but I think the behavior should play nicely together.
mjhenkes
approved these changes
Jun 26, 2023
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
Electron doesn't support multiple tabs/windows so calling
connectToNewSpecin electron doesn't make sense. This change will callopeninstead which will ensure all the shutdown and startup logic associated with launching a new electron window is properly handled.Steps to test
How has the user experience changed?
Potentially shutdown and startup issues are now properly handled.
PR Tasks
cypress-documentation?type definitions?