Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress not finding beta/dev builds of Edge on linux #25611

Closed
CarbonCollins opened this issue Jan 27, 2023 · 4 comments
Closed

Cypress not finding beta/dev builds of Edge on linux #25611

CarbonCollins opened this issue Jan 27, 2023 · 4 comments
Assignees

Comments

@CarbonCollins
Copy link
Contributor

Current behavior

After installing Edge Beta and Edge Dev on my machine I do not see them listed as an option to run my E2E tests against. The Stable version does appear in the UI with no issues.

Desired behavior

After installing Edge Beta and Edge Dev on my machine I should see them listed as an option to run my E2E tests against
Test code to reproduce

Test code to reproduce

There is no test code to run as the bug appears before any tests are run.

Cypress Version

12.4.1

Node version

v18.12.1

Operating System

Manjaro Linux 6.0.15-1-MANJARO

Debug Logs

No response

Other

After looking into how Cypress knows about browsers I noticed two potential issues with the version regex in the packages/launcher/lib/browsers.ts file and the binary names.

For the version regex I'm not sure if this would be the cause of the issue but the regex for Edge Dev is /Microsoft Edge Dev (\S+)/m and for Edge Beta is /Microsoft Edge Beta (\S+)/m but when running /usr/bin/microsoft-edge-dev --version it returns Microsoft Edge 110.0.1587.6 dev which would not match the regex string. This is the same for the beta version where it returns Microsoft Edge 109.0.1518.49 beta

Re-opened issue as the previous one #25455 was closed upon release with only 1 of the fixes merged

@CarbonCollins
Copy link
Contributor Author

The remaining PR that solves the version matching: #25457

@emilyrohrbough
Copy link
Member

@CarbonCollins oh shoot....this was not expected to have been a 2 part PR. The summary text partially closes https://github.com/cypress-io/cypress/issues/25455 automatically closed this issue as resolved.

@CarbonCollins
Copy link
Contributor Author

It happens :D

Just so the two issues are linked at least ill mention the other on here #25455

@mschile
Copy link
Contributor

mschile commented Jan 31, 2023

Closing as a duplicate of #25455. The other issue was reopened instead. Both PRs have been merged and were released in Cypress 12.5.0.

@mschile mschile closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants