Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress not finding beta/dev builds of Edge on linux #25455

Closed
CarbonCollins opened this issue Jan 13, 2023 · 6 comments · Fixed by #25457 or #25456
Closed

Cypress not finding beta/dev builds of Edge on linux #25455

CarbonCollins opened this issue Jan 13, 2023 · 6 comments · Fixed by #25457 or #25456
Labels
E2E Issue related to end-to-end testing

Comments

@CarbonCollins
Copy link
Contributor

Current behavior

After installing Edge Beta and Edge Dev on my machine I do not see them listed as an option to run my E2E tests against. The Stable version does appear in the UI with no issues.

Desired behavior

After installing Edge Beta and Edge Dev on my machine I should see them listed as an option to run my E2E tests against

Test code to reproduce

There is no test code to run as the bug appears before any tests are run.

Cypress Version

12.3.0

Node version

v18.12.1

Operating System

Manjaro Linux 6.0.15-1-MANJARO

Debug Logs

No response

Other

After looking into how Cypress knows about browsers I noticed two potential issues with the version regex in the packages/launcher/lib/browsers.ts file and the binary names.

For the version regex I'm not sure if this would be the cause of the issue but the regex for Edge Dev is /Microsoft Edge Dev (\S+)/m and for Edge Beta is /Microsoft Edge Beta (\S+)/m but when running /usr/bin/microsoft-edge-dev --version it returns Microsoft Edge 110.0.1587.6 dev which would not match the regex string. This is the same for the beta version where it returns Microsoft Edge 109.0.1518.49 beta

The second potential issue I see is that the Edge Beta is missing a listing for microsoft-edge-beta which is present for the stable and dev versions. This looks like it was done in #8931 but the beta and canary channels were missed.

@CarbonCollins
Copy link
Contributor Author

I have raised #25456 to add the alternate binary names for Edge Beta and Edge Canary

@CarbonCollins
Copy link
Contributor Author

#25457 was also raised to potentially resolve the version string matching

@chrisbreiding
Copy link
Contributor

Thanks for posting this issue and particularly for the PRs to fix it. We'll take a look at them and get back to you with any feedback.

@chrisbreiding chrisbreiding removed their assignment Jan 17, 2023
@CarbonCollins
Copy link
Contributor Author

CarbonCollins commented Jan 26, 2023

This issue still has an open PR, there were two issues found causing Cypress not to be able to find the Edge binaries. One being Manjaro linux has microsoft- as a prefix to the binary names and that Cypress version regex is not matching the format that Edge is returning when running edge --version

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 27, 2023

Released in 12.4.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.4.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 27, 2023
@ZachJW34 ZachJW34 reopened this Jan 27, 2023
@nagash77 nagash77 added routed-to-e2e E2E Issue related to end-to-end testing labels Jan 27, 2023
@cypress-io cypress-io unlocked this conversation Jan 31, 2023
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 31, 2023

Released in 12.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E2E Issue related to end-to-end testing
Projects
None yet
4 participants