Added: '-force-prune' to remove workers not on the heartbeat list #8
Conversation
CHANGELOG.md
Outdated
| ### Added | ||
|
|
||
| - New flag `-force-prune` to remove workers not on the heartbeat list | ||
| ([PR #8](https://github.com/cycloidio/goworker/issues/8)) |
| // This option is not compatible with older | ||
| // versions of Resque (any port) as older versions | ||
| // may not have heartbeat so this would delete | ||
| // real working workers. |
There was a problem hiding this comment.
How would that work for onpremise setup? Anything that should be of concern?
There was a problem hiding this comment.
The main issue would be to use it in conjuntion with running workers, the idea would be to restart all workers with the new version if this flag want's to be used. Old ones are ones that do not have the heartbeat logic which since 0.15 is enabled
There was a problem hiding this comment.
So as long as the flag is added to updated workers we're good?
There was a problem hiding this comment.
Yes if the workers are using this lib with v0.15=> it'll work fine, if not this will "kill" any old worker.
The option is disabled by default for this reason. It'll fail if the version used of resque does not support This flag is also just for cleanup, it does not need to be enabled all time normally. Fixed the comment. |
| // This option is not compatible with older | ||
| // versions of Resque (any port) as older versions | ||
| // may not have heartbeat so this would delete | ||
| // real working workers. |
There was a problem hiding this comment.
So as long as the flag is added to updated workers we're good?
This will remove workers thare could be stuck but it's not backwards compatible if enabled
|
What are we waiting for? |
This will remove workers thare could be stuck but it's not backwards compatible if enabled