Initialize Pretty formatter with output stream when autoformatting #599
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System: Win 7 Ultimate x64
Console: MsysGit (bash)
Ruby: ruby 1.9.3p392 (2013-02-22) [i386-mingw32]
Does NOT occur before v1.3.0. Tested on 1.2.5, 1.3.0, 1.3.9.
From what I can see, nil is passed (as the IO object) to
Formatter::Pretty.new
when autoformat is used (in Configuration#formatters).The crash happens when
@IO.puts
is called with@IO == nil
.The workaround I've found is to specify the
--no-profile
(-P
) flag when using--autoformat
. If there's no profile, print_profile_information exits early and puts is not called.