Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): change type for title from string to ReactNode #1389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VladislavNsk
Copy link
Contributor

@VladislavNsk VladislavNsk commented Sep 23, 2024

Опишите проблему

В заголовок модалки нужно добавить react элемент
Сейчас TS ругается что title должен быть строкой

Шаги для воспроизведения

<Modal.Header
    title={ (
        <TitleView
            tag="div"
            view={ VIEWS.LARGE }
            subtitle="Подзаголовок"
        >
            Операции по{ NBSP }счёту
        </TitleView>
    ) }
    hasCloser={ true }
/>
`

# Ожидаемое поведение
При добавлении React элемента в пропс title, TS не выдается ошибку

# Чек лист
- [ ] Тесты
- [ ] Документация

# Внешний вид

Ожидаемый        | Фактический
:---------------:|:--------------------|
** Ожидаемый  ** | ** Фактический    **|

# Тестовый стенд

## Десктоп (если данных нет оставте блок пустым):

## Смартфон (если данных нет оставте блок пустым):

# Дополнительная информация

Copy link

changeset-bot bot commented Sep 23, 2024

⚠️ No Changeset found

Latest commit: 343ba9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant