Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: international-phone-input: add lazy load for global data #1308

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Jul 22, 2024

Опишите проблему

Топ-10 пользователям не требуются все международные коды и их флаги. Это драфт, где можно обсудить подгрузку. По дефолту приезжают exUssr набор.

Шаги для воспроизведения

Стенд: https://core-ds.github.io/core-components/feat_DS_5366_c44983542a30237b8142abfdc9091ae3e37b448c/?path=/story/internationalphoneinput--international-phone-input

Ожидаемое поведение

Подгрузки данных: в селекте флагов, в самом конце "Ещё"

Чек лист

Внешний вид

Тестовый стенд

Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: 0e533f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@coveralls
Copy link

coveralls commented Jul 23, 2024

Pull Request Test Coverage Report for Build 10058154938

Details

  • 25 of 26 (96.15%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 83.416%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/international-phone-input/src/components/base-international-phone-input/Component.tsx 15 16 93.75%
Totals Coverage Status
Change from base Build 10008543980: 0.01%
Covered Lines: 10131
Relevant Lines: 11155

💛 - Coveralls

@core-ds core-ds deleted a comment from core-ds-bot Jul 23, 2024
@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@Oladii
Copy link
Contributor

Oladii commented Aug 29, 2024

Реквест еще жив? обсуждали, насколько помню, что кнопка ещё не подходит, так как сбивается сортировка.

@denisx
Copy link
Contributor Author

denisx commented Aug 29, 2024

пока на паузе, много чего поменять нужно

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants