Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: international-phone-input - add missing flags #1306

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denisx
Copy link
Contributor

@denisx denisx commented Jul 18, 2024

Опишите проблему

В компоненте international-phone-input добавлены флаги 'Сент-Пьер и Микелон' и 'Уоллис и Футуна'

Шаги для воспроизведения

В селекте флагов, у указанных городов появятся флаги
Увеличение объёма сборки: 8кб zip

Внешний вид

было:
Screenshot 2024-07-18 at 21 04 11

стало:
Screenshot 2024-07-18 at 21 02 27

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 5654570

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@core-ds-bot
Copy link
Collaborator

Bundle size report

Entry point Size (minified)
international-phone-input/desktop.js 620.1 (+42.30 KB🔺)
international-phone-input/index.js 654.8 (+42.30 KB🔺)
international-phone-input/mobile.js 626.8 (+42.30 KB🔺)

@core-ds-bot
Copy link
Collaborator

Собрана новая демка.

@SiebenSieben SiebenSieben requested a review from Oladii July 19, 2024 06:16
@Oladii
Copy link
Contributor

Oladii commented Jul 19, 2024

А для чего мы в последнее время добавляем все французские колонии в этот контрол?
Вобщем, на всякий случай, для уоллиса вот нормальный флаг, а для сент-пьера нужно брать французский
https://www.figma.com/design/RHkvF3gsacdtwxSCgOCWV0/Flags?m=auto&t=XUTY26j669ywtfGg-1

@Oladii
Copy link
Contributor

Oladii commented Aug 29, 2024

По итогу, флаги не заменили на те что я сбросил. Или просто новой демки нет)

Тут должен быть триколор республики
image

@denisx
Copy link
Contributor Author

denisx commented Aug 29, 2024

тут пока на паузе. но сделаем

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants