Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue related to SSL inputStream #379

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Fix issue related to SSL inputStream #379

merged 3 commits into from
Jul 20, 2022

Conversation

sandeepkota
Copy link
Contributor

InputStream is getting closed as the scope usage is not proper.

	at com.coralogix.zio.k8s.client.config.TrustManagers.createTrustStore(TrustManagers.scala:63)
	at com.coralogix.zio.k8s.client.config.TrustManagers.apply(TrustManagers.scala:77)
	at com.coralogix.zio.k8s.client.config.SSL.secureSSLContext(SSL.scala:47)
	at com.coralogix.zio.k8s.client.config.SSL.secureSSLContext(SSL.scala:38)
	at com.coralogix.zio.k8s.client.config.httpclient.package.k8sSttpClient(package.scala:35)
	at com.coralogix.zio.k8s.client.config.httpclient.package.k8sSttpClient(package.scala:22)```

vigoo
vigoo approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vigoo vigoo merged commit 5b9feeb into coralogix:zio2 Jul 20, 2022
vigoo added a commit that referenced this pull request Mar 28, 2023
@vigoo @sandeepkota
@jkobejs @gavares @sergigp @gregoryEvlash @pwliwanow
ZIO 2 version (#327)
2851347 
* Upgrade to ZIO 2.0 (#310)

* Upgrade to ZIO 2.0

* added environment type and fixed some logging issues

* running scalafmt

* upgrade (#324)

* upgrade

* asGeneric

* exclude 2.13 collection-compat

* Fix sbt issue

* import layer ops

Co-authored-by: Daniel Vigovszky <daniel.vigovszky@gmail.com>

* release from zio2

* releases when we have push on master, publishes docs for v1.* versions (#328) (#330)

* Upgrade to ZIO 2.0.0-RC5 (#347)

* Initial Commit

Still one test failing in LeaseLockSpec related to a fiber not being
interrupted when clock skew occurs

TODO: remove debugging in LeaseLockSpec

* @wip - add more debug logging for testing purposes

* @wip more debugging

* addressing review comments

* Address MR updates. LeaseLockSpec now passes

* Run scalafmtAll to fix bad formatting

* Fix CRD support

* Update documentation

* Fix documentation

* Fix rest of mdoc issues

Co-authored-by: ggavares <grant.gavares@oracle.com>
Co-authored-by: Sandeep Kota <sandeep.kota@oracle.com>
Co-authored-by: Daniel Vigovszky <daniel.vigovszky@gmail.com>

* ZIO 2.0.0 RC6 (#349)

* ZIO 2.0.0 RC6

* Fixes

* mdoc fix

* ZIO 2.0.0 (#377)

* releases when we have push on master, publishes docs for v1.* versions (#328)

* releases when we have push on master, publishes docs for v1.* versions

* release when v2.* is pushed

* Update sbt-mdoc to 2.3.1 (#321)

* Update quicklens to 1.8.4 (#331)

* Update quicklens to 1.8.5 (#339)

* Update sbt-mdoc to 2.3.2 (#335)

* Update sbt-api-mappings to 3.0.2 (#333)

* Update scala3-library to 3.1.1 (#301)

* Improve error reporting (#338)

* add namespace to K8sRequestInfo

* add namespace selectors and resource name K8sRequestInfo

* print new data from request info to error to make debug easier

* improve error formatting

* expose stream to let clients handle errors and set their own repeat policy (#341)

* Fix release triggering

* Update quicklens to 1.8.7 (#348)

* Update zio, zio-streams, zio-test, ... to 1.0.14 (#342)

* Update scala3-library to 3.1.2 (#343)

* Update circe-core, circe-generic, ... to 0.14.2 (#352)

* Update quicklens to 1.8.8 (#350)

* Update bcpkix-jdk15on to 1.71 (#357)

* Update zio, zio-streams, zio-test, ... to 1.0.15 (#359)

* Make ssl builder public (#361)

* Fix API compatibility for `com.softwaremill.quicklens 1.8.7+` version for scala 3 (#363)

* use kind instaed of resource type (#372)

* Update zio, zio-streams, zio-test, ... to 1.0.16 (#376)

* Update scala-library to 2.12.16 (#360)

* Update scala3-library to 3.1.3 (#362)

* Upgrade to final ZIO 2.0.0

* Fix docs

Co-authored-by: Josip Grgurica <josip.grgurica@protonmail.com>
Co-authored-by: Sergi GP <sergigp85@gmail.com>
Co-authored-by: Gregory Evlash <4488614+gregoryEvlash@users.noreply.github.com>

* Fix issue related to SSL inputStream (#379)

* fix issue related to SSL inputStream

* adding back System, mistakenly removed

* formatting files

Co-authored-by: Sandeep Kota <sandeep.kota@oracle.com>

* Remove Clock as a dependency from Resource.watch functions (#403)

* Update Scala, ZIO, STTP, SBT and quicklens dependencies (#458)

Co-authored-by: Pawel Iwanow <7759586+pwliwanow@users.noreply.github.com>

* Removing remaining Clocks from environment

* Fix docs

---------

Co-authored-by: Sandeep Kota <sandeepkota@users.noreply.github.com>
Co-authored-by: Josip Grgurica <josip.grgurica@protonmail.com>
Co-authored-by: Grant <gavares@gmail.com>
Co-authored-by: ggavares <grant.gavares@oracle.com>
Co-authored-by: Sandeep Kota <sandeep.kota@oracle.com>
Co-authored-by: Sergi GP <sergigp85@gmail.com>
Co-authored-by: Gregory Evlash <4488614+gregoryEvlash@users.noreply.github.com>
Co-authored-by: pwliwanow <pwliwanow@users.noreply.github.com>
Co-authored-by: Pawel Iwanow <7759586+pwliwanow@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigoo vigoo vigoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandeepkota @vigoo