Add (hard coded) colour key for events on TCC map #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commonknowledge-bot
deployed
to
feat/add-key-for-TCC-map-colours - meep-database PR #121
Render
Active
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-backend PR #121
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-backend PR #121
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-frontend PR #121
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-worker PR #121
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-backend PR #121
Render
Destroyed
commonknowledge-bot
temporarily deployed
to
feat/add-key-for-TCC-map-colours - meep-intelligence-hub-frontend PR #121
Render
Destroyed
|
Just to note there is more than one hub. There is also Tipping Point's expression of much of this data. So there does need to be some manner of switch here. |
that will apply to everything right? So the copy as well? |
joaquimds
approved these changes
Jul 9, 2024
|
I'm going to hold off on merging this until TCC have new events to be loaded to the map. Then I'll adjust the icon labels as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a colour key for the events on the TCC map. It can be updated to reflect new event types and their colours.
It also commits copies of the svg icons to the repo.
N.B. this is hard coded because it's for TCC only and both the hub specific check and the copy is also hard coded
Motivation and Context
Addresses issue CC-173
Screenshots (if appropriate):
Types of changes