Add content-type filter method to folder_paths #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huchenlei
reviewed
Jul 18, 2024
| @@ -0,0 +1,52 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Thanks for adding tests!
|
Hmmm, the github runner is not picking up the job |
huchenlei
approved these changes
Jul 19, 2024
huchenlei
added
the
Good PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video, audio, image files are all in input dir. I addeed
folder_paths.filter_files_content_types()to filter files by mimetype. It lazily caches extension -> content-type mappings, so it can be used by other nodes efficiently. Then I changed LoadAudio to filter for audio and video files in input dir, instead of only allowing'.wav', '.mp3', '.ogg', '.flac', '.aiff', '.aif'. Better solution than #3941.