Allow resolving moduleDeps with older Scala 3 versions #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
force-pushed
the
resolve-scala-3-version
branch
3 times, most recently
from
38de173
to
64486bb
Compare
lefou
reviewed
Jan 8, 2024
lolgab
force-pushed
the
resolve-scala-3-version
branch
from
64486bb
to
49e2ee4
Compare
lefou
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes you want different modules in a build to have different Scala 3 versions, one the older and one the newer.
The current resolve implementation in
CrossModuleBaseis tailored to Scala 2 since it assumes that the binary version isx.ywhile in Scala 3 it's just the first part.This change adapts the algorithm to consider 1 or 2 parts depending if it is Scala 3 or not.
Pull Request: #2877