Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make run command arguments Tasks #2452

Merged
merged 22 commits into from
May 1, 2023
Merged

Make run command arguments Tasks #2452

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
517abc2
compiles
lihaoyi Apr 27, 2023
1b71b89
.
lihaoyi Apr 27, 2023
ffe5cfe
introduce mill.Args
lihaoyi Apr 27, 2023
fe67585
.
lihaoyi Apr 27, 2023
05a355f
.
lihaoyi Apr 27, 2023
0790389
.
lihaoyi Apr 27, 2023
30bf4fc
.
lihaoyi Apr 27, 2023
43e3004
tweak imports
lihaoyi Apr 27, 2023
95d3732
.
lihaoyi Apr 27, 2023
447409a
.
lihaoyi Apr 27, 2023
1a8d93e
.
lihaoyi Apr 27, 2023
ccf2c41
.
lihaoyi Apr 27, 2023
cb48d1f
tweak
lihaoyi Apr 27, 2023
ff9e82e
.
lihaoyi Apr 27, 2023
707f492
.
lihaoyi Apr 29, 2023
1f765fe
compiles
lihaoyi Apr 29, 2023
d45b57b
updat-epatch
lihaoyi Apr 29, 2023
75532bc
update-patch
lihaoyi Apr 29, 2023
8698024
Update main/define/src/mill/define/Discover.scala
lihaoyi Apr 30, 2023
bf6f879
merge0
lihaoyi Apr 30, 2023
c47d0ef
update-patch
lihaoyi Apr 30, 2023
2a0b3e3
Merge remote-tracking branch 'origin/run-takes-tasks' into run-takes-…
lihaoyi Apr 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update-patch
  • Loading branch information
@lihaoyi
lihaoyi committed Apr 29, 2023
commit 75532bc1ad6744d960ee2a5116698f0e276496b9
13 changes: 12 additions & 1 deletion ci/mill-bootstrap.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
diff --git a/build.sc b/build.sc
index b6b06b7584..b49a252914 100644
index b6b06b7584..8c62146aef 100644
--- a/build.sc
+++ b/build.sc
@@ -2,34 +2,26 @@
Expand Down Expand Up @@ -438,6 +438,17 @@ index b6b06b7584..b49a252914 100644

def moduleDeps = Seq(scalalib, scalajslib, scalanativelib, runner.test)

@@ -1681,8 +1443,8 @@ object dev extends MillModule {
mill.modules.Jvm.createJar(Agg(), mill.modules.Jvm.JarManifest(manifestEntries))
}

- def run(args: String*) = T.command {
- args match {
+ def run(args: Task[Args] = T.task(Args())) = T.command {
+ args().value match {
case Nil => mill.api.Result.Failure("Need to pass in cwd as first argument to dev.run")
case wd0 +: rest =>
val wd = os.Path(wd0, T.workspace)
@@ -1709,67 +1471,11 @@ object docs extends Module {
def moduleDeps = build.millInternal.modules.collect { case m: MillApiModule => m }

Expand Down