feat: TokenRow component #399
Conversation
kyhyco
force-pushed
the
ky.lee/feat/token-row
branch
from
10f1a1a
to
4edcb3a
Compare
kyhyco
force-pushed
the
ky.lee/feat/token-row
branch
from
4edcb3a
to
8af07a6
Compare
| if (amount === undefined) { | ||
| return ''; | ||
| } |
There was a problem hiding this comment.
fail more gracefully
| @@ -59,7 +60,8 @@ | |||
| "yarn": "^1.22.21" | |||
| }, | |||
| "resolutions": { | |||
| "@coinbase/wallet-sdk": "npm:@coinbase/wallet-sdk@4.0.0" | |||
| "@coinbase/wallet-sdk": "npm:@coinbase/wallet-sdk@4.0.0", | |||
| "react": "npm:react@^18" | |||
There was a problem hiding this comment.
I was getting errors on github actions with packemon v3.3.1 dependency boost/cli depending on react 16 / 17.
This is more of a temp fix and we need to upgrade packemon to v4 which uses a version of boost/cli that depends on react 18
kyhyco
force-pushed
the
ky.lee/feat/token-row
branch
from
55608f4
to
b4c466b
Compare
src/token/components/TokenRow.tsx
Outdated
|
|
||
| export const TokenRow = memo(function TokenRow({ token, amount, onClick }: TokenRowReact) { | ||
| return ( | ||
| <div data-testid="tokenRow" style={styles.row} onClick={() => onClick?.(token)}> |
There was a problem hiding this comment.
Not a fan of all these divs, I wonder if we can be a more semantic with our HTML tags
There was a problem hiding this comment.
@Zizzamia Updated the root to be button and converted divs to spans. Marginally better... let me think on this a bit more.
src/token/components/TokenRow.tsx
Outdated
| <div data-testid="tokenRow" style={styles.row} onClick={() => onClick?.(token)}> | ||
| <div style={styles.left}> | ||
| {token.image === null ? ( | ||
| <div data-testid="noTokenImage" style={styles.circle} /> |
There was a problem hiding this comment.
because we share data-testid with other components, let's as standard a prefix_ like ockTokenRow_~~~
so ock + NameComponent + _ + ElToTest
a bit similar to what we did in https://github.com/coinbase/onchainkit/blob/main/src/identity/components/Avatar.tsx#L34
There was a problem hiding this comment.
what does ock stand for?
kyhyco
force-pushed
the
ky.lee/feat/token-row
branch
from
b4c466b
to
ec08d65
Compare
What changed? Why?
Notes to reviewers
How has it been tested?
locally