Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] include peer dependency for graphql@15 and graphql@16 #270

Merged
merged 2 commits into from
Apr 10, 2024
Merged

[feature] include peer dependency for graphql@15 and graphql@16 #270

merged 2 commits into from
Apr 10, 2024

Conversation

benson-budiman-cb
Copy link
Contributor

What changed? Why?

This PR includes the peer dependency for graphql@15 and graphql@16. Why? So that other projects that are on the later versions of graphql can install onchainkit without peer dependency issues.

Notes to reviewers

Ran yarn install after manually updating package.json.

How has it been tested?

npm run test still works.

@Zizzamia Zizzamia merged commit fcbb194 into coinbase:main Apr 10, 2024
5 of 6 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Merged
@benson-budiman-cb benson-budiman-cb deleted the feature/include-graphql-16-as-dep branch May 27, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyhyco kyhyco kyhyco approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benson-budiman-cb @kyhyco @Zizzamia