Fix default url #60
Open
Fix default url #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
ineoactually fails to install via the method indicated in thereadme.md:If you examine
~/.ineo/bin/ineoyou will find that its file size is 0 (at least in my case on Ubuntu 21.04 it was).The "problem" is ofcourse on line 362 because the installation in this case (where the script is downloaded and sent to bash) is not started by
ineoand is "re-downloaded" from the hostname (which is set on line 48, which now is not pointing to the correct URL, which fails silently, which results in anineowith 0 file size :/ ).This PR corrects that so that the latest version available on github is picked up.
This might not be what you are after though (because the last version on github might be the last "development" version) and it might be worth the "trouble" to set up github releases (which makes it even easier to pick up whatever file the latest release would point to).
This addresses issues:
#56 #57 #58
Hope this helps.