Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed more args in cleo_return than caller expected in legacy modes. #176

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

MiranDMC
Copy link
Collaborator

@MiranDMC MiranDMC commented Aug 2, 2024

image
Fixes error occurring in Junior's Tuning Mod
In old Cleo target variables of not provided return values were just unmodified after call.

@MiranDMC MiranDMC requested a review from x87 August 2, 2024 21:46
@x87
Copy link

x87 commented Aug 2, 2024

As I said some time ago, it might be a good idea to disable all validation in legacy mode by default, rather than constantly fine tuning it

@MiranDMC
Copy link
Collaborator Author

MiranDMC commented Aug 2, 2024

As I said some time ago, it might be a good idea to disable all validation in legacy mode by default, rather than constantly fine tuning it

Yes, and it is generally done that way. All warnings are silenced globally by legacy modes.
Some other cases produce crashes or undefined behaviors (like returning more that expected values in 0AB2), and these critical errors need to be checked and handled with error message.

Changes scope of this PR shows it was meant to work that way.

There is for sure many obscure scenarios nobody even think about yet and those will come out in testing.

@MiranDMC MiranDMC merged commit 62fe46d into master Aug 3, 2024
2 checks passed
@MiranDMC MiranDMC deleted the cleo_return_arg_count_in_legacy_mode branch August 3, 2024 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants