Various fixes #164
Merged
Various fixes #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x87
approved these changes
Jul 21, 2024
x87
reviewed
Jul 21, 2024
| @@ -542,7 +542,7 @@ class MemoryOperations | |||
| static OpcodeResult __stdcall opcode_0AC7(CLEO::CRunningScript* thread) | |||
| { | |||
| auto resultType = thread->PeekDataType(); | |||
| if (!IsVariable(resultType) && IsVarString(resultType)) | |||
| if (!IsVariable(resultType) && !IsVarString(resultType)) | |||
There was a problem hiding this comment.
case DT_VAR:
case DT_VAR_ARRAY:
case DT_LVAR:
case DT_LVAR_ARRAY:
Is it done this way as some arrays related stuff? Worth consideration as it can be what else if not an number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problem found by Vital where it was impossible to get pointer of longstring variable.
Fixes problem found by 123nir where RZL trainer was throwing error due to declared-provided argument count missmatch in function/method call opcodes.