Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): add getters for neons #2785

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(server): add getters for neons #2785

wants to merge 1 commit into from
+477 −267

Conversation

ahcenezdh
Copy link
Contributor

@ahcenezdh ahcenezdh commented Sep 11, 2024 •
edited
Loading

Goal of this PR

  • Added 2 getters GetVehicleNeonColour(), GetVehicleNeonEnabled()

How is this PR achieving the goal

By reading/write bits in CVehicleAppearanceDataNode

For crew things needs more test/check some data could be wrong here

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 3095

Platforms: Windows, Linux

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

Fixes issues

@ahcenezdh
feat(netcode): Complete CVehicleAppearanceDataNode
02ea63f 
* Sync neons vehicle, so we don't use statebags anymore to sync it
* Added 2 getters GetVehicleNeonColour(), GetVehicleNeonEnabled()
* Sync vehicle crew (needs to be tested)
@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 11, 2024
@ahcenezdh
Copy link
Contributor Author

ahcenezdh commented Sep 11, 2024 •
edited
Loading

For vehicle mods, metadata parsing are needed, not possible atm

@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Sep 11, 2024
@ahcenezdh ahcenezdh changed the title feat(netcode): Complete CVehicleAppearanceDataNode feat(server): add getters for neons Sep 16, 2024
@prikolium-cfx prikolium-cfx added ready-to-merge This PR is enqueued for merging and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prikolium-cfx prikolium-cfx prikolium-cfx approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR is enqueued for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcenezdh @prikolium-cfx