Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nui): hide mouse cursor when the css cursor property is set to none #2753

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kajkul
Copy link
Contributor

@kajkul kajkul commented Aug 26, 2024

Goal of this PR

Hide the mouse cursor when it is over an element with css property cursor: none.

How is this PR achieving the goal

It checks in the OnCursorChange handler if the type is CT_NONE and changes g_isCursorHidden accordingly, which is added to the checks performed in NUIRenderCallback.cpp to determine whether the cursor should be displayed.

This PR applies to the following area(s)

FiveM, RedM, NUI

Successfully tested on

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@github-actions github-actions bot added RedM Issues/PRs related to RedM invalid Requires changes before it's considered valid and can be (re)triaged labels Aug 26, 2024
@kajkul
Copy link
Contributor Author

kajkul commented Aug 26, 2024

Don't know why the check failed. It doesn't look like anything related to this PR.

@Mathu-lmn
Copy link
Contributor

Don't know why the check failed. It doesn't look like anything related to this PR.

Yup, the cfx team is aware that the pipeline for linux server build is broken for now. A fix might come soon !

@prikolium-cfx prikolium-cfx added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RedM Issues/PRs related to RedM triage Needs a preliminary assessment to determine the urgency and required action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants