fix(ui-build): Fix for Cannot read properties of null (reading 'focus')
#2649
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
invalid
MuDzYNN
changed the title
Cannot read properties of null (reading 'focus')
|
It might be good to know why its null. Maybe its a symptom of another bug. |
prikolium-cfx
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
When NUI is initializing in nui console you always see:
This error is regarding to line:
frame.contentWindow.focus();and i'm just added question marks to avoid displaying this error.How is this PR achieving the goal
As above I'm just added question marks, so when frame or frame.contentWindow is null nothing happen.
This PR applies to the following area(s)
ui-build