Add support for compilation on wasm32-wasi #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn‘t really resolve my issue. It‘s a good change, but the idea was to make now() work with WASI. In fact it already does compile on wasm32-wasi, even without this PR. But the removal of some unnecessary dependencies is good regardless. |
|
It does compile without this, but the presence of wasm-bindgen in the dependency tree at all would add a bunch of |
|
I agree that this is an improvement, but we still want some more features to fully close out #352 |
|
Also thank you very much for the contribution @coolreader18 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just disables
wasmbindfrom taking effect on WASI. Resolves #352.