[ENH] Pulsar Producer & Consumer #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
commented
Aug 1, 2023
| @@ -0,0 +1,39 @@ | |||
| syntax = "proto3"; | |||
There was a problem hiding this comment.
TODO: add a readme on how to generate protos
There was a problem hiding this comment.
TODO: mypy ignore protos
## Description of changes *Summarize the changes made by this PR.* - New functionality - Adds a pulsar consumer - Add pulsar admin api - Hardcoded to default tenant/namespace. Need to support this in coordinator. ## Test plan Will add fixtures for this config ## Documentation Changes None
atroyn
approved these changes
Sep 20, 2023
tazarov
pushed a commit
to amikos-tech/chroma-core
that referenced
this pull request
Sep 21, 2023
## Description of changes *Summarize the changes made by this PR.* - New functionality - Adds a basic pulsar producer, consumer and associated tests. As well as a docker compose for the distributed version of chroma. ## Test plan We added bin/cluster-test.sh, which starts pulsar and allows test_producer_consumer to run the pulsar fixture. ## Documentation Changes None required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
We added bin/cluster-test.sh, which starts pulsar and allows test_producer_consumer to run the pulsar fixture.
Documentation Changes
None required.