-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix JS client regression #2026
Conversation
Fix regression that stopped running the JS client unit tests during CI. Both regressions are from a large PR: chroma-core#1970.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Do not mix npm and yarn as this leads to unnecessary complexity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you @ibratoev !!! Good catch
It seems a GO test failed. I looked into the test and the issue is that in the GO metastore collection tests, a particular order for collections is expected. The collections are currently returned ordered by id which is UUID -> random. This makes the test flaky and should fail every second run. I will prepare a quick fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ibratoev ! This was a miss on my part -- I appreciate the thoroughness.
The Golang tests are flaky right now and we're working on them. I'm happy to merge this without them.
Fix regression that stopped running the JS client unit tests during CI.
Both regressions are from a large PR: #1970.