Proof P12 #611 #672
Merged
Proof P12 #611 #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wopian
requested changes
Jun 2, 2020
Luminary099/P12.agc
Outdated
| @@ -91,14 +91,14 @@ P12LMB DLOAD | |||
| MXV VSL6 | |||
| REFSMMAT | |||
| STCALL R # COMPUTE R = POS(TIG)*2(-24) M. | |||
| MUNGRAV # COMPUTE GDT1/2(TIG)*2(-T)M/CS. | |||
| MUNGRAV # COMPUTE GDT1/2(TIG)*2(-7) M/CS. | |||
There was a problem hiding this comment.
❌ There's no space between (-7) and M/CS on L0040
There was a problem hiding this comment.
Ok, then I'll also remove the space from the 89 and 93 lines of code
Luminary099/P12.agc
Outdated
| @@ -200,7 +200,7 @@ P12INIT DLOAD # INITIALIZE ENGINE DATA. USED FOR P12 AND | |||
| COMMINIT DLOAD DAD # INITIALIZE TARGET DATA. USED BY P12, P70 | |||
| HINJECT # AND P71 IF IT DOES NOT FOLLOW P70. | |||
| /LAND/ | |||
| STODL RCO | |||
| STODL RCD | |||
There was a problem hiding this comment.
Definitely looks like RCD from the low-res scans, will need to check the following Luminary099 files that define/reference the variable.
- ASCENT_GUIDANCE.agc L221, L222 and L576
- ERASABLE_ASSIGNMENT.agc L2614 (the variable definition) and L2615
There was a problem hiding this comment.
From the high-res scans this is supposed to be RCO and not RCD, the O and D characters are incredible difficult to distinguish when not printed correctly.
ERASABLE_ASSIGNMENT variable definition:
Luminary210 with the same variable definition with much higher print quality
wopian
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checked for typos with the reduced quality scans.
I didn't check for the line breaks though..