Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proof STABLE_ORBIT #640

Closed
wopian opened this issue Feb 20, 2020 · 8 comments · Fixed by #674
Closed

Proof STABLE_ORBIT #640

wopian opened this issue Feb 20, 2020 · 8 comments · Fixed by #674
Labels
Size: Small 250 to 499 lines
Milestone
Luminary099

Comments

@wopian
Copy link
Collaborator

wopian commented Feb 20, 2020 •
edited
Loading

Proof read transcribed code of STABLE_ORBIT against scans

Lines: 441
Page: 0723—0730 (7)

Reduced quality scans can be found here
@wopian wopian added this to the Luminary099 milestone Feb 20, 2020
@wopian wopian added Size: Small 250 to 499 lines and removed Size: Moderate 500 to 749 lines labels Feb 20, 2020
@NotJustSid
Copy link
Contributor

Hey @wopian! I am new here... Can I take this one?

@wopian
Copy link
Collaborator Author

wopian commented Jun 5, 2020 •
edited
Loading

@sid200 go ahead! 👍

@NotJustSid
Copy link
Contributor

NotJustSid commented Jun 5, 2020 •
edited
Loading

Uhh... Was that @ supposed to be for me or nope? 😂

@wopian
Copy link
Collaborator Author

wopian commented Jun 5, 2020

Oops

@NotJustSid
Copy link
Contributor

Alrighty thanks!

@NotJustSid
Copy link
Contributor

NotJustSid commented Jun 6, 2020 •
edited
Loading

Hey, I am done checking. There were some line break issues, two hyphens instead of one in the comments, and a date was wrong. There's just one error I am not sure of. Is this line in 0726.jpg:

image

supposed to be a decimal point or a comma? I guess it's a decimal point, but I am not sure.

@wopian
Copy link
Collaborator Author

wopian commented Jun 7, 2020

@sid200 It's a decimal point.

@NotJustSid
Copy link
Contributor

NotJustSid commented Jun 7, 2020 •
edited
Loading

Ok I am done checking. Here are the corrections:

  • Changed the double hyphens with a single one as per the scans.
  • Changed the date from 26JAN68 to 25JAN68
  • Changed a comma to a decimal point. (7,1 to 7.1)
  • Removed extra line breaks.

Opened a PR.

@wopian wopian linked a pull request Jun 9, 2020 that will close this issue
Proof STABLE_ORBIT #640 #674
Merged
wopian added a commit that referenced this issue Jun 9, 2020
@NotJustSid @wopian
Proof STABLE_ORBIT #640 (#674)
d1b3a20 
* STABLE_ORBIT Typo corrections

* Apply suggestions from code review

Co-authored-by: James Harris <wopian@wopian.me>
@wopian wopian removed the Help Wanted label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Size: Small 250 to 499 lines
Projects
None yet
Milestone
Luminary099
Development

Successfully merging a pull request may close this issue.

Proof STABLE_ORBIT #640 NotJustSid/Apollo-11
2 participants
@wopian @NotJustSid