Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the design won't synthesize in Vivado due to syntax errors #39

Closed
monniaux opened this issue Feb 24, 2020 · 3 comments
Closed

the design won't synthesize in Vivado due to syntax errors #39

monniaux opened this issue Feb 24, 2020 · 3 comments

Comments

@monniaux
Copy link

The Vivado synthetizer does not like the ' in
rden <= '0;
wren <= '0;

I don't know anything about Verilog.
The following fixes the syntax issues but I'm unsure whether this actually works :

diff --git a/design/dmi/dmi_jtag_to_core_sync.v b/design/dmi/dmi_jtag_to_core_sync.v
index aa4c19f..2d1477c 100644
--- a/design/dmi/dmi_jtag_to_core_sync.v
+++ b/design/dmi/dmi_jtag_to_core_sync.v
@@ -48,8 +48,8 @@ module dmi_jtag_to_core_sync (
 // synchronizers  
 always @ ( posedge clk or negedge rst_n) begin
     if(!rst_n) begin
-        rden <= '0;
-        wren <= '0;
+        rden <= 0;
+        wren <= 0;
     end
     else begin
         rden <= {rden[1:0], rd_en};
@aprnath
Copy link
Collaborator

aprnath commented Feb 24, 2020

Thanks for pointing this out. The change for PR #29 somehow got dropped in this release.

@olofk
Copy link
Collaborator

olofk commented Feb 24, 2020

That's strange. I just updated SweRVolf to use SweRV 1.5 and didn't see any issues with Vivado. Doing standalone Vivado synthesis (e.g. with fusesoc run --target=synth chipsalliance.org:cores:SweRV_EH1 --part=xc7a100tcsg324-1) also works fine

@aprnath
Copy link
Collaborator

aprnath commented Feb 24, 2020

Re-applied PR #29 via commit cb5a7a1
Thanks for reporting this.

@aprnath aprnath closed this as completed Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants