Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise RTL styling #105

Closed
guywillis opened this issue Dec 15, 2023 · 1 comment · Fixed by #106
Closed

Optimise RTL styling #105

guywillis opened this issue Dec 15, 2023 · 1 comment · Fixed by #106
Assignees
@guywillis
Labels
enhancement New feature or request released

Comments

@guywillis
Copy link
Contributor

Subject of the enhancement

The RTL styling present in the preview.less and visua11ySettings.less files could be optimised a touch better by utilising the margin-inline and padding-inline properties instead of the current approach.

The margin-inline and padding-inline properties do not require an associated RTL version as the property inherits the body direction.

Your environment

  • Master
@guywillis guywillis added the enhancement New feature or request label Dec 15, 2023
@guywillis guywillis self-assigned this Dec 15, 2023
@guywillis guywillis mentioned this issue Dec 15, 2023
Merged
kirsty-hames pushed a commit that referenced this issue Dec 18, 2023
@guywillis
Update: Updated RTL styling (fixes #105) (#106)
1e660f1 
* Updated RTL styling

* Button close RTL update

* Readability item RTL padding update
github-actions bot pushed a commit that referenced this issue Dec 18, 2023
@semantic-release-bot
Chore(release): 2.8.0 [skip ci]
63a38f8 
# [2.8.0](v2.7.0...v2.8.0) (2023-12-18)

### Update

* Updated RTL styling (fixes #105) (#106) ([1e660f1](1e660f1)), closes [#105](#105) [#106](#106)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 2.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guywillis guywillis

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update: Updated RTL styling (fixes #105) cgkineo/adapt-visua11y
1 participant
@guywillis