-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS support, fix #9, function parameters #10
Conversation
The decompiler might fail on certain functions for any number of reasons, and they may not even be functions that matter for debugging purposes. Handle this situation gracefully by outputting an error comment to the decompiled source and skipping line number generation.
Hey, thank you so much for your contribution, we appreciate it! We would like to avoid distributing binaries from untrusted (a.k.a. not us) sources. We plan to build libdwarf automatically via CI and hopefully it will happen very soon™ (likely today), so this should fix that issue for good. On a side note, you probably have noticed that the code is horrible (mostly because it never exited the prototype phase). |
Thank you! I understand the concern about the untrusted binary - makes sense. I am looking forward to the rewrite - this project is immensely useful in its current state already. |
We started working today on the CI for compiling libdwarf in a cross-platform way on https://github.com/cesena/libdwarf-ghidra2dwarf, so it will be available soon hopefully :) thank you for your support! |
453bb3d should have officially added macOS support. Please let us know if you have trouble with it! |
Fantastic! I pulled the new changes and tested with macOS Ghidra - works like a charm. |
This patchset introduces a few fixes and improvements to ghidra2dwarf:
get_decompiled_function
to cut down on script execution timeformal_parameter
tags for function parameters to improve backtraces and debugging experiencedefaultFieldName
iffieldName
is not available (the segfault is caused by a segfault from passing a NULL pointer through to alibdwarf
function).