Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Solved the name inconsistancy bugs for ChatAgent #366

Merged
merged 14 commits into from
Nov 13, 2023

Conversation

FUYICC
Copy link
Contributor

@FUYICC FUYICC commented Nov 13, 2023

Description

Renaming model to model_type in ChatAgent

#337

Motivation and Context

#337

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@FUYICC FUYICC self-assigned this Nov 13, 2023
@lightaime lightaime added the Agent Related to camel agents label Nov 13, 2023
@lightaime
Copy link
Member

lightaime commented Nov 13, 2023

The PR looks good. There are some missing places. I just fixed it. Thanks @FUYICC! BTW, next time you can clone the original repo directly instead of forking it since some tests will fail by forking due to the github secretes.

@lightaime lightaime merged commit 2431c4e into camel-ai:master Nov 13, 2023
3 of 7 checks passed
@L4zyy L4zyy mentioned this pull request Dec 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agent Related to camel agents
Projects
Status: Merged or Closed
Development

Successfully merging this pull request may close these issues.

4 participants