Fix agent mypy error
#206
Merged
Fix agent mypy error
#206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Obs01ete This PR also fix all the mypy error with nested agents. WDYT? |
|
Yeah, this fixes inheritance inconsistencies, that's fine, formally. However it kinda makes no sense architecturally. If you were to apply dependency inversion and cast CriticAgent to ChatAgent or to BaseAgent to abstract away the concrete inplementation, |
|
Secondly, what do you think about this: |
Obs01ete
approved these changes
Jul 6, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply: