-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve TextPrompt
and add docs
#127
Conversation
@@ -10,7 +10,7 @@ jobs: | |||
- uses: actions/setup-python@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,17 @@ | |||
name: GPT Commits summarizer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,12 +1,78 @@ | |||
from typing import Any, Dict, Set | |||
import inspect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 255b6f - 49a377:
- Imported
inspect
module and addedT
type variable - Added
return_text_prompt
decorator andwrap_text_prompt_functions
decorator - Updated
TextPrompt
class to extendstr
class and addedkey_words
property - Updated
format
method to return aTextPrompt
instance with the formatted string
@@ -6,3 +6,38 @@ sphinx-apidoc -o docs camel/ | |||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 2cf7c2 - e55af4:
- Instructions added for installing CAMEL from source
- Instructions added for installing Sphinx, Sphinx theme and recommonmark
- Instructions added for building the documentation with
make
- Instructions added for launching the HTML documentation from the terminal using a local HTTP server
@@ -1,4 +1,4 @@ | |||
camel package | |||
Camel Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -11,17 +11,25 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,112 @@ | |||
# Write Your Prompts with the `TextPrompt` Class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The
TextPrompt
class is a subclass of the built-instr
class and provides additional features for working with text prompts. - It provides a property called
key_words
, which returns a set of strings representing the key words in the prompt. - It also provides a
format
method to allow for partial formatting values in the format string. - It can be manipulated with various string manipulation operations, such as concatenation, joining, and applying string methods.
@@ -1,14 +1,26 @@ | |||
.. Camel documentation master file, created by | |||
.. CAMEL documentation master file, created by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 1824dd0: Error: couldn't generate summary |
GPT summary of 22ce3d6:
|
GPT summary of e11720f: Not generating summary for merge commits PR summary so far:
|
… improve_text_prompt
@@ -1,11 +1,69 @@ | |||
from camel.prompts import TextPrompt, TextPromptDict | |||
from camel.prompts.base import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GPT summary of 58172b - b5bfbf:
- Added functions
return_text_prompt
andwrap_text_prompt_functions
to theTextPrompt
base class. - Added tests for
return_text_prompt
andwrap_text_prompt_functions
. - Added tests for
TextPrompt
'skey_words
andformat
methods. - Added tests for
TextPrompt
'smanipulate
andupper
methods.
GPT summary of 9e00c2f:
|
GPT summary of 3002141: Not generating summary for merge commits PR summary so far:
|
TextPrompt
and add docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall seems good
docs/README.md
Outdated
2. Install Sphinx, Sphinx theme and `recommonmark` (Sphinx extension that enables Markdown support) by running the following command in your terminal or command prompt: | ||
```bash | ||
pip install sphinx | ||
pip install sphinx-rtd-theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have already moved to the book theme. Replace with:
pip install sphinx_book_theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
permissions: write-all # Some repositories need this line | ||
|
||
steps: | ||
- uses: KanHarI/gpt-commit-summarizer@master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to remove this action. Its span is irritating. I can see the code myself, I do not need trivial comments on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
No description provided.