Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure PostgresAdapter::useIdentity is always initialized #2223

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Ensure PostgresAdapter::useIdentity is always initialized #2223

merged 1 commit into from
Sep 20, 2023

Conversation

othercorey
Copy link
Member

@othercorey othercorey commented Sep 19, 2023 •
edited
Loading

This is causing issues with packages that run their own Manager and use setConnection() directly.

@othercorey othercorey added this to the 0.15.x milestone Sep 19, 2023
@othercorey othercorey mentioned this pull request Sep 19, 2023
Merged
MasterOdin
MasterOdin approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine not having a test as it's not super easily tested change since we don't directly expose this property, and would have to get at it as part of introspection of constructed SQL which is brittle.

@MasterOdin MasterOdin merged commit acda135 into 0.x Sep 20, 2023
12 checks passed
@MasterOdin MasterOdin deleted the init-postgres-useidenitty branch September 20, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15.x
Development

Successfully merging this pull request may close these issues.
2 participants
@othercorey @MasterOdin