Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2193 Postgres GENERATED ALWAYS #2195

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Fix 2193 Postgres GENERATED ALWAYS #2195

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6fcca69
Update the postgres generated clause to GENERATED BY DEFAULT to allow…
captain-redbeard May 13, 2023
72ae5b3
Copied insert statements from PdoAdapter and updated to include OVERR…
captain-redbeard May 13, 2023
217841d
Update PostgresAdapter unit tests with expected output.
captain-redbeard May 13, 2023
d8357eb
Update PostgresAdapter unit tests with default generated clause.
captain-redbeard May 13, 2023
003ade4
Only override system value if Postgres version is greater than or equ…
captain-redbeard May 13, 2023
16843ef
Add checks for Postgres version and coding standard fix.
captain-redbeard May 13, 2023
e7dbe87
Another Postgres version check.
captain-redbeard May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Another Postgres version check.
  • Loading branch information
@captain-redbeard
captain-redbeard committed May 13, 2023
commit e7dbe87fefe055ed9113bb9ab704104c83ae8aa1
9 changes: 9 additions & 0 deletions tests/Phinx/Db/Adapter/PostgresAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2297,6 +2297,15 @@ public function testDumpInsert()
INSERT INTO "public"."table1" ("string_col") OVERRIDING SYSTEM VALUE VALUES (null);
INSERT INTO "public"."table1" ("int_col") OVERRIDING SYSTEM VALUE VALUES (23);
OUTPUT;

if (!$this->usingPostgres10()) {
$expectedOutput = <<<'OUTPUT'
INSERT INTO "public"."table1" ("string_col") VALUES ('test data');
INSERT INTO "public"."table1" ("string_col") VALUES (null);
INSERT INTO "public"."table1" ("int_col") VALUES (23);
OUTPUT;
}

$actualOutput = $consoleOutput->fetch();
$this->assertStringContainsString(
$expectedOutput,
Expand Down