Add default values for hive fields for Node, UnspentCoinsInfo, Wallet… #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Info, Order, Contact, TransactionDescription, Trade
OmarHatem28
reviewed
Nov 4, 2022
Comment on lines
42
to
43
| @HiveField(2) | ||
| WalletType type; |
There was a problem hiding this comment.
is this guaranteed it won't be null?
Comment on lines
+45
to
46
| @HiveField(4, defaultValue: '') | ||
| late String stateRaw; |
There was a problem hiding this comment.
with the current implementation of the constructor, this variable may not be initialized if the state is null, resulting in a late variable not initialized exception
Comment on lines
+62
to
63
| @HiveField(9, defaultValue: 0) | ||
| late int providerRaw; |
There was a problem hiding this comment.
with the current implementation of the constructor, this variable may not be initialized if the provider is null, resulting in a late variable not initialized exception
Comment on lines
+26
to
27
| @HiveField(2, defaultValue: 0) | ||
| late int raw; |
There was a problem hiding this comment.
with the current implementation of the constructor, this variable may not be initialized if the type is null, resulting in a late variable not initialized exception
Comment on lines
+46
to
47
| @HiveField(1, defaultValue: 0) | ||
| late int providerRaw; |
Comment on lines
+52
to
63
| @HiveField(2, defaultValue: 0) | ||
| late int fromRaw; | ||
|
|
||
| CryptoCurrency get from => CryptoCurrency.deserialize(raw: fromRaw); | ||
|
|
||
| @HiveField(3) | ||
| @HiveField(3, defaultValue: 0) | ||
| late int toRaw; | ||
|
|
||
| CryptoCurrency get to => CryptoCurrency.deserialize(raw: toRaw); | ||
|
|
||
| @HiveField(4) | ||
| @HiveField(4, defaultValue: '') | ||
| late String stateRaw; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Info, Order, Contact, TransactionDescription, Trade