Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional Buy Provider #1071

Merged
merged 27 commits into from
Sep 14, 2023
Merged

Add additional Buy Provider #1071

merged 27 commits into from
Sep 14, 2023

Conversation

konstantinullrich
Copy link
Contributor

Description

Please include a summary of the changes and which issue is fixed / feature is added.

Pull Request - Checklist

  • Initial Manual Tests Passed
  • Double check modified code and verify it with the feature/task requirements
  • Format code
  • Look for code duplication
  • Clear naming for variables and methods

@OmarHatem28 OmarHatem28 changed the title Add additional Buy Provider Robinhood Integration Sep 1, 2023
@OmarHatem28 OmarHatem28 changed the title Robinhood Integration Add additional Buy Provider Sep 1, 2023
Copy link
Contributor

@OmarHatem28 OmarHatem28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only a few comments most of them are minor

lib/buy/robinhood/robinhood_buy_provider.dart Outdated Show resolved Hide resolved
lib/entities/preferences_key.dart Show resolved Hide resolved
res/values/strings_ar.arb Show resolved Hide resolved
lib/store/settings_store.dart Show resolved Hide resolved
lib/buy/robinhood/robinhood_buy_provider.dart Outdated Show resolved Hide resolved
lib/buy/robinhood/robinhood_buy_provider.dart Outdated Show resolved Hide resolved
@OmarHatem28
Copy link
Contributor

OmarHatem28 commented Sep 8, 2023

@konstantinullrich please fix this conflict when you get a chance

@OmarHatem28 OmarHatem28 merged commit d972363 into main Sep 14, 2023
1 check passed
@OmarHatem28 OmarHatem28 deleted the CW-466-Robinhood-Buy-SDK branch September 14, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants