Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some classes are deprecated #17

Merged
merged 8 commits into from
Jun 14, 2021
Merged

Some classes are deprecated #17

merged 8 commits into from
Jun 14, 2021

Conversation

glebsterx
Copy link
Contributor

AlarmControlPanel is deprecated and should be replaced by AlarmControlPanelEntity
BinarySensorDevice is deprecated and should be replaced by BinarySensorEntity
Lightis deprecated and should be replaced by LightEntity
MediaPlayerDevice is deprecated and should be replaced by MediaPlayerEntity

Light is deprecated and should be replaced by LightEntity
BinarySensorDevice is deprecated and should be replaced by BinarySensorEntity
MediaPlayerDevice is deprecated and should be replaced by MediaPlayerEntity
AlarmControlPanel is deprecated and should be replaced by AlarmControlPanelEntity
Update alarm_control_panel.py
@cadavre cadavre mentioned this pull request Jun 14, 2021
@cadavre
Copy link
Owner

cadavre commented Jun 14, 2021

Hi @here, sorry for very late response. Github doesn't give me notifications (need to investigate) and as I'm not using Miio gateway – I wasn't digging into this repo.

Can you, observers and 👍 ers confirm that this works so we can merge it and provide future support?

This was referenced Jun 14, 2021
@cliffordwhansen
Copy link
Contributor

@cadavre I can confirm this is working (I am not home so haven't seen the motion/windows open, but gateway LED works)
image

@cadavre cadavre merged commit 821e5d7 into cadavre:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants