Add Support for File Content HTTP Responses #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually this has a couple of small problems that i found during more extensive testing. i'm hoping to send an update to this PR sometime soon |
avoids sending the file data in response to every single request issued after the one for the file.
|
alright, seems ok now, at least based on all the testing i know how to do. |
bykof
reviewed
Sep 11, 2018
| @@ -73,6 +73,18 @@ The params have to look like this (there are not default values for the params!) | |||
| } | |||
| ``` | |||
|
|
|||
| ### sendFileResponse(responseObject, callbackSuccess, callbackError) (currently Android-only support) | |||
There was a problem hiding this comment.
You are exporting exports.sendFile
I don't know if the name "sendFile" is really the right method name. It should be more like "retrieveFile" or "getFileByPath"...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses some of the demo NanoHTTPD code to enable support for sending the contents of a file in the response to an HTTP request. It currently only provides this support for Android because I don't any Apple to develop or test an implementation for iOS.