Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for FutureGetBestBlockHashResult.Receive #2048

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ClaytonNorthey92
Copy link
Contributor

Adding a few tests to cover func (f FutureGetBestBlockHashResult) Receive(). I've noticed that rpcclient has 0.6% test coverage (before this PR):

$ git log -1
commit ad26585576912588d213dbe973b222fcec621546 (HEAD, origin/master, origin/HEAD)
Author: David Cardenas <47157243+davidcardenasus@users.noreply.github.com>
Date:   Tue Oct 17 02:47:09 2023 -0700

$ go-acc ./rpcclient
ok  	github.com/btcsuite/btcd/rpcclient	0.148s	coverage: 0.6% of statements in ./rpcclient

this PR bumps it up to 0.9%

$ go-acc ./rpcclient
ok  	github.com/btcsuite/btcd/rpcclient	0.234s	coverage: 0.9% of statements in ./rpcclient

I want to keep adding tests but I want to do them in their own PRs: as some tests will be larger than others, I don't want the PR(s) to be too big and unreadable.

@jcvernaleo
Copy link
Member

One test per PR to keep them small makes perfect sense to me.

Copy link
Member

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcvernaleo jcvernaleo merged commit 208800c into btcsuite:master Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants