Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up packages #112

Merged
merged 6 commits into from
Sep 28, 2024
Merged

Clean up packages #112

merged 6 commits into from
Sep 28, 2024

Conversation

kylewlacy
Copy link
Member

@kylewlacy kylewlacy commented Sep 28, 2024

This PR includes some general minor cleanup across lots of packages:

  • Update brioche.lock for go package. I missed this before merging [go] Improve Go package and update to v1.23.1 #111
  • Update all remaining std.download() recipes to use Brioche.download() where possible (this was supposed to be done in Update all packages to use Brioche.download where possible #104 but quite a few packages were missed)
  • Switch to using .unarchive() in places where a workaround was needed due to Failed to peel the archive from ruff brioche#103
  • Update k9s package to use Brioche.gitRef() + gitCheckout(). This ensures that the git commit hash for the build matches the actual source code commit
  • Use export default function () { ... } instead of export default () => { ... }; everywhere
    • This isn't a "set in stone" decision, but I'd prefer to stick to one in the packages repo, and I believe export default function () { ... } has the edge (namely: you can define a function that is both exported as the default and has a local name, see this diff from go for an example). Open to bikeshedding on this though!

@kylewlacy kylewlacy merged commit 987d8c4 into main Sep 28, 2024
3 checks passed
@kylewlacy kylewlacy deleted the package-cleanup branch September 28, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant