Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more bot platforms #542

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

luciomartinez
Copy link
Contributor

Hey,

I thought it might be helpful to have a few more popular bots besides Google bot (already registered as a platform).

This list is not extensive, yet it includes the most popular ones worldwide, including the main Russian and Chinese search engines.

One of the down sides of having this list is its maintenance, so feel free to skip it from merging if you deem it so.

Thanks,
Lucio.

@lancedikson
Copy link
Collaborator

Hi @luciomartinez! Sorry it took a while to get back to your PR. If you still available, can you please also add tests for these platforms so that we have examples in the tests?


/* Baidu */
{
test: [/baiduspider/i],
Copy link
Contributor Author

@luciomartinez luciomartinez Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Bingbot */
{
test: [/bingbot/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* DuckDuckBot */
{
test: [/duckduckbot/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -18,6 +18,105 @@ export default [
},
},

/* AmazonBot */
{
test: [/Amazonbot/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Internet Archive Crawler */
{
test: [/ia_archiver/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Meta Web Crawler */
{
test: [/facebookexternalhit/i, /facebookcatalog/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Yahoo! Slurp */
{
test: [/yahoo/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Yandex */
{
test: [/yandexbot/i, /yandexmobilebot/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


/* Pingdom */
{
test: [/pingdom/i],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best guest I suppose 🙂

@luciomartinez
Copy link
Contributor Author

luciomartinez commented Aug 21, 2024

CI logs don't show exactly which test is failing.

Trying to build it locally, I get this error:

$ npm run build

> bowser@2.11.0 build
> webpack --config webpack.config.js

node:internal/crypto/hash:79
  this[kHandle] = new _Hash(algorithm, xofLen, algorithmId, getHashCache());
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:79:19)
    at Object.createHash (node:crypto:139:10)
    at module.exports (/workspaces/bowser/node_modules/webpack/lib/util/createHash.js:135:53)
    at NormalModule._initBuildHash (/workspaces/bowser/node_modules/webpack/lib/NormalModule.js:417:16)
    at /workspaces/bowser/node_modules/webpack/lib/NormalModule.js:452:10
    at /workspaces/bowser/node_modules/webpack/lib/NormalModule.js:323:13
    at /workspaces/bowser/node_modules/loader-runner/lib/LoaderRunner.js:367:11
    at /workspaces/bowser/node_modules/loader-runner/lib/LoaderRunner.js:233:18
    at context.callback (/workspaces/bowser/node_modules/loader-runner/lib/LoaderRunner.js:111:13)
    at /workspaces/bowser/node_modules/babel-loader/lib/index.js:55:103 {
  opensslErrorStack: [
    'error:03000086:digital envelope routines::initialization error',
    'error:0308010C:digital envelope routines::unsupported'
  ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

Node.js v20.16.0

I'm not sure what I'm doing wrong here 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants